Async wrapper #25
Open
Async wrapper #25
+150
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliuskoval
commented
Feb 22, 2025
| private bool _checked = false; | ||
| private bool _isWrapped; | ||
|
|
||
| public bool IsWrapped |
There was a problem hiding this comment.
Is there a better way to check if the target is wrapped?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is largely based on 1d56102.
Here are benchmarks for comparison
The top is without the change, the bottom with the change if I don't check for whether the target is wrapped. Interestingly, more memory is allocated on .NET 8.0 in the second case. Both were for async=false.